From bed946b4a0da710c3b051a8c7c62f08fa5f7b868 Mon Sep 17 00:00:00 2001
From: Noa Aarts <noa@voorwaarts.nl>
Date: Sun, 6 Oct 2024 21:50:47 +0200
Subject: [PATCH] feat: improve perf 4x by not incrementing the atomic counter
 every time

---
 src/main.rs | 61 +++++++++++++++++++++++++++++++++--------------------
 1 file changed, 38 insertions(+), 23 deletions(-)

diff --git a/src/main.rs b/src/main.rs
index d5cf72d..1a02b2f 100644
--- a/src/main.rs
+++ b/src/main.rs
@@ -62,8 +62,8 @@ fn get_pixel(
 }
 
 #[inline]
-fn increment_counter() {
-    COUNTER.fetch_add(1, std::sync::atomic::Ordering::Relaxed);
+fn increment_counter(amount: u64) {
+    COUNTER.fetch_add(amount, std::sync::atomic::Ordering::Relaxed);
 }
 
 #[derive(Debug, PartialEq)]
@@ -156,6 +156,7 @@ where
     writer: BufWriter<W>,
     grids: Arc<[Flut<u32>]>,
     parser: ParserTypes,
+    counter: u64,
 }
 
 impl<R, W> FlutClient<R, W>
@@ -205,7 +206,7 @@ where
             Color::W8(white) => u32::from_be_bytes([*white, *white, *white, 0xff]),
         };
         set_pixel_rgba(self.grids.as_ref(), canvas, x, y, c);
-        increment_counter();
+        self.counter += 1;
     }
 
     fn change_canvas_command(&mut self, canvas: Canvas) -> io::Result<()> {
@@ -225,33 +226,47 @@ where
             writer: BufWriter::new(writer),
             grids,
             parser: ParserTypes::TextParser(TextParser::new(0)),
+            counter: 0,
+        }
+    }
+
+    async fn parse_command(&mut self, command: Result<Command, std::io::Error>) -> io::Result<()> {
+        match command {
+            Ok(Command::Help) => self.help_command().await,
+            Ok(Command::Size(canvas)) => self.size_command(canvas).await,
+            Ok(Command::GetPixel(canvas, x, y)) => self.get_pixel_command(canvas, x, y).await,
+            Ok(Command::SetPixel(canvas, x, y, color)) => {
+                self.set_pixel_command(canvas, x, y, &color);
+                Ok(())
+            }
+            Ok(Command::ChangeCanvas(canvas)) => self.change_canvas_command(canvas),
+            Ok(Command::ChangeProtocol(protocol)) => {
+                self.change_protocol(&protocol);
+                Ok(())
+            }
+
+            Err(err) if err.kind() == ErrorKind::UnexpectedEof => {
+                return Ok(());
+            }
+            Err(e) => {
+                return Err(e);
+            }
         }
     }
 
     pub async fn process_socket(&mut self) -> io::Result<()> {
         loop {
-            let parsed = match &self.parser {
-                ParserTypes::TextParser(parser) => parser.parse(&mut self.reader).await,
-                ParserTypes::BinaryParser(parser) => parser.parse(&mut self.reader).await,
-            };
+            for _ in 0..1000 {
+                let parsed = match &self.parser {
+                    ParserTypes::TextParser(parser) => parser.parse(&mut self.reader).await,
+                    ParserTypes::BinaryParser(parser) => parser.parse(&mut self.reader).await,
+                };
 
-            match parsed {
-                Ok(Command::Help) => self.help_command().await?,
-                Ok(Command::Size(canvas)) => self.size_command(canvas).await?,
-                Ok(Command::GetPixel(canvas, x, y)) => self.get_pixel_command(canvas, x, y).await?,
-                Ok(Command::SetPixel(canvas, x, y, color)) => {
-                    self.set_pixel_command(canvas, x, y, &color);
-                }
-                Ok(Command::ChangeCanvas(canvas)) => self.change_canvas_command(canvas)?,
-                Ok(Command::ChangeProtocol(protocol)) => self.change_protocol(&protocol),
-
-                Err(err) if err.kind() == ErrorKind::UnexpectedEof => {
-                    return Ok(());
-                }
-                Err(e) => {
-                    return Err(e);
-                }
+                self.parse_command(parsed).await?;
             }
+
+            increment_counter(self.counter);
+            self.counter = 0;
         }
     }
 }