If I can find out how to make it work without the double definition

i'll be happy

modules/waybar/allmodules.nix

@@ -0,0 +1,4 @@
+config: 
+  [ "hyprland/workspaces" "tray" "hyprland/window" ] ++ 
+  [ "clock" ] ++ 
+  [ "custom/vpn" "wireplumber" "network" "cpu" "memory" "custom/poweroff" ]

modules/waybar/createmodules.nix

@@ -0,0 +1 @@
+config: builtins.listToAttrs (import ./namedmodules.nix config)

modules/waybar/default.nix

@@ -1,8 +1,6 @@
 { config, pkgs, lib, ... }:
 let
   cfg = config.modules.waybar;
-
-  ifIsDef = name: builtins.any (row: builtins.any (x: x == name) row) (with cfg.modules; [left center right]);
 in
 {
   options.modules.waybar = {
@@ -42,10 +40,7 @@ in
   ];
 
   config = lib.mkIf cfg.enable {
-    modules.waybar = {
-      clock.enable = ifIsDef "clock";
-      "hyprland/workspaces".enable = ifIsDef "hyprland/workspaces";
-    };
+    modules.waybar = import ./createmodules.nix cfg.modules;
     home.packages = with pkgs; [
       font-awesome
     ];

modules/waybar/namedmodules.nix

@@ -0,0 +1,4 @@
+config:
+  builtins.map 
+    (n: {name = n; value = {enable = true;}; })
+    (import ./allmodules.nix config)

modules/waybar/power.nix

@@ -15,7 +15,7 @@ in
     programs.waybar.settings.mainBar."${name}" = {
       format = "";
       on-click = "wofi-power";
-      # on-click-right = "swaylock"; # TODO: change to whatever lock screen i want
+      on-click-right = "swaylock"; # TODO: change to whatever lock screen i want
     };
   };
 }